[PATCH] The check of !S_ISDIR(sb.st_mode) in second time is wrong since it's already known to be false at that point.

[Nicholas Marriott]

Hmm, thanks - judging by the last comments the guy in the ticket had some misapprehensions about how tmux works. I think we should remove the S_ISDIR check per Dmitry's diff since it is clearly unnecessary.

I think I'll also make tmux-%u under TMUX_TMPDIR unless some problem occurs to me before I get home.

-------- Original message --------
From: Thomas Adam <***@xteddy.org>
Date:18/01/2015 21:15 (GMT+00:00)
To: Nicholas Marriott <***@gmail.com>
Cc: Dmitri Paduchikh <***@gmail.com>,tmux-users <tmux-***@lists.sourceforge.net>
Subject: Re: [PATCH] The check of !S_ISDIR(sb.st_mode) in second time is wrong since it's already known to be false at that point.

On 18 January 2015 at 20:32, Nicholas Marriott

I'm not sure what the original intent of the change was and I don't
understand the commit message (below).
It seems like the second !S_ISDIR check is both unnecessary and
backwards... Thomas?

Seems it was related to this:  https://sourceforge.net/p/tmux/tickets/66/

Hmm.  I thought the steps to reproduce that were clear; perhaps not,
and perhaps my patch is effectively useless.

-- Thomas Adam